-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sys.get_reg() function to eldritch. #362
Conversation
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 75.13% 74.91% -0.23%
==========================================
Files 103 104 +1
Lines 6818 6892 +74
==========================================
+ Hits 5123 5163 +40
- Misses 1599 1633 +34
Partials 96 96
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple fixes but looks really good. Love the testing 🤌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change to remove unwrap but then good to send 🚀
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Added sys.get_reg() function to eldritch. only installs on windows systems.
$> sys.get_reg("HKEY_LOCAL_MACHINE","SOFTWARE\Microsoft\Windows\CurrentVersion")
{
"ProgramFilesDir": "C:\Program Files",
"CommonFilesDir": "C:\Program Files\Common Files",
"ProgramFilesDir (x86)": "C:\Program Files (x86)",
"CommonFilesDir (x86)": "C:\Program Files (x86)\Common Files",
"CommonW6432Dir": "C:\Program Files\Common Files",
"DevicePath": "%SystemRoot%\inf",
"MediaPathUnexpanded": "%SystemRoot%\Media",
"ProgramFilesPath": "%ProgramFiles%",
"ProgramW6432Dir": "C:\Program Files",
"SM_ConfigureProgramsName": "Set Program Access and Defaults",
"SM_GamesName": "Games"
}
Which issue(s) this PR fixes:
Fixes #358