Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hostname and add tome. #338

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Fix hostname and add tome. #338

merged 5 commits into from
Oct 29, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Oct 29, 2023

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

Fixes a binding issue with hostname and adds a tome to run the command.

Which issue(s) this PR fixes:

Fixes #

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #338 (ec5e685) into main (4b403b4) will decrease coverage by 0.02%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   75.20%   75.19%   -0.02%     
==========================================
  Files         101      101              
  Lines        6607     6612       +5     
==========================================
+ Hits         4969     4972       +3     
- Misses       1551     1553       +2     
  Partials       87       87              
Files Coverage Δ
implants/lib/eldritch/src/lib.rs 92.75% <100.00%> (ø)
implants/lib/eldritch/src/sys/hostname_impl.rs 84.61% <ø> (ø)
implants/lib/eldritch/src/sys.rs 49.36% <60.00%> (+0.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hulto hulto merged commit 8048cff into main Oct 29, 2023
@hulto hulto deleted the fix-hostname branch October 29, 2023 23:35
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Fix hostname and add tome. (#338)

* Update docs.

* Hostname tome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants