GH2153: Fix async stack traces rendering as MoveNext() instead of source methods#2154
Merged
Merged
Conversation
…) instead of source methods Async exception stack frames were showing `async void MoveNext()` because `TryResolveStateMachineMethod` took `MethodBase` by value. The resolved method (e.g. `ExecuteAsync`) was assigned to a local copy and never propagated back to the caller, matching .NET StackTrace behavior only partially. - Pass `MethodBase` by ref in `TryResolveStateMachineMethod` and at its call site in `GetMethodName` - Add async throw helpers to `TestExceptions` for regression coverage - Add verifier test and snapshot asserting resolved async method names - Fixes spectreconsole#2153
patriksvensson
approved these changes
Jun 18, 2026
Contributor
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
This was referenced Jun 24, 2026
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Async exception stack frames were showing
async void MoveNext()becauseTryResolveStateMachineMethodtookMethodBaseby value. The resolved method (e.g.ExecuteAsync) was assigned to a local copy and never propagated back to the caller, matching .NET StackTrace behavior only partially.MethodBaseby ref inTryResolveStateMachineMethodand at its call site inGetMethodNameTestExceptionsfor regression coverageExample
Before fix (broken — MethodBase passed by value)
After fix (ref MethodBase — matches .NET StackTrace)
Please upvote 👍 this pull request if you are interested in it.