Fix escaping of interpolated arguments in markup#2118
Merged
patriksvensson merged 1 commit intoMay 12, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f59f08e to
fa2b54d
Compare
This was referenced Jun 11, 2026
This was referenced Jun 12, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1763
Changes
Previously, only string arguments were escaped in
Markup.EscapeInterpolated.This caused runtime crashes when non-string objects were interpolated and their
ToString()output contained markup-sensitive characters (e.g. square brackets), which were then interpreted as markup.This change ensures that all interpolated arguments are consistently converted to string and escaped before formatting, preventing unintended markup parsing and runtime exceptions.
A regression test was added for objects whose
ToString()contains square brackets.Please upvote 👍 this pull request if you are interested in it.