Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Enricher for Azure Pipelines #1675

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Adding Enricher for Azure Pipelines #1675

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51dd772
Adding Enricher for Azure Pipelines
BlazeFace Nov 3, 2024
4173a90
Update Check
BlazeFace Nov 4, 2024
fc62172
Invert Check
BlazeFace Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Spectre.Console/Enrichment/CI/AzurePipelinesEnricher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,8 @@ internal sealed class AzurePipelinesEnricher : IProfileEnricher

public bool Enabled(IDictionary<string, string> environmentVariables)
{
if (environmentVariables.TryGetValue("TF_BUILD", out var value))
{
return value?.Equals("true", StringComparison.OrdinalIgnoreCase) ?? false;
}

return false;
environmentVariables.TryGetValue("TF_BUILD", out var environmentValue);
return string.IsNullOrWhiteSpace(environmentValue);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression needs to be inverted, otherwise the enricher will always be enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be updated with the inversion!

}

public void Enrich(Profile profile)
Expand Down