Add TypeResolver to ExceptionHandler #1325
Closed
+195
−107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR
PR #1
PR #2
This one is the 2nd of 3 PR's. Different flavors for the same problem.
I believe this one is somewhat the cleanest approach, even if there is quite a bit of change.
Why do i need this? TL;DR when using Logging, for e.g microsoft.extensions.logging, i cannot access the logger without a TypeResolver in order to log the exception details.
Changes
Add TypeResolver to ExceptionHandler while trying to not break the api.
If the user chose to set the handler directly through the settings, their code might be broken.
But if the user uses
SetExceptionHandler
, everything is fine, i have made an overload for that.