Fix DefaultValue for FileInfo and DirectoryInfo #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xced
force-pushed
the
fix-DefaultValue-FileInfo-DirectoryInfo
branch
from
dcbad8e to
ff6b956
Compare
Contributor
|
Thanks @0xced, I've added this to my list to review in the next few weeks. |
Commit d3f4f5f introduced automatic conversion to FileInfo and DirectoryInfo but failed to properly handle the conversion if the value comes from the [DefaultValue] attribute. Using both `var (converter, stringConstructor) = GetConverter(...)` and `var (converter, _) = GetConverter(...)` should have been a red flag!
0xced
force-pushed
the
fix-DefaultValue-FileInfo-DirectoryInfo
branch
from
ff6b956 to
2848f0c
Compare
FrankRay78
approved these changes
Sep 21, 2023
Contributor
|
Really nice refactoring performed in this PR @0xced, big improvement to the readability of the codebase (along with the functionality too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d3f4f5f introduced automatic conversion to FileInfo and DirectoryInfo but failed to properly handle the conversion if the value comes from the [DefaultValue] attribute.
Using both
var (converter, stringConstructor) = GetConverter(...)andvar (converter, _) = GetConverter(...)should have been a red flag!