Allow Confirmation Prompt Styling #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
@patriksvensson curious about your thoughts on this one and if there are any issues with the proposed changes here. 😄 |
0xced
added a commit
to 0xced/spectre.console
that referenced
this pull request
Nov 9, 2023
This will allow to slightly simplify the implementation of spectreconsole#1210 See also related discussion on spectreconsole#1349 (comment)
patriksvensson
pushed a commit
that referenced
this pull request
Nov 10, 2023
This will allow to slightly simplify the implementation of #1210 See also related discussion on #1349 (comment)
Co-authored-by: Cédric Luthi <[email protected]>
Co-authored-by: Cédric Luthi <[email protected]>
Co-authored-by: Cédric Luthi <[email protected]>
Co-authored-by: Cédric Luthi <[email protected]>
Co-authored-by: Cédric Luthi <[email protected]>
Co-authored-by: Cédric Luthi <[email protected]>
|
@0xced applied your suggestions. Thanks for the review! |
0xced
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows styling of
ConfirmationPromptin the same way thatTextPromptcan be styled for choices and default values.If no style is provided, fallback to the same
"blue"and"green"thatTextPromptuses is done.Addresses #1209.