Changes from code review

spectreconsole · Jan 28, 2022 · 4732d14 · 4732d14
1 parent 05b7517
commit 4732d14
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/Spectre.Console/Widgets/GridColumn.cs b/src/Spectre.Console/Widgets/GridColumn.cs
@@ -17,7 +17,7 @@ public sealed class GridColumn : IColumn, IHasDirtyState
 
     /// <summary>
     /// Gets or sets the width of the column.
-    /// The interpretation of width depends on the value of <see cref="SizeMode"/>.<br/>
+    /// The interpretation of width depends on the value of <see cref="SizeMode"/>.
     /// <br/>
     /// By default it is set to <see langword="null"/>, and the column will size to its contents <see cref="SizeMode.SizeToContent"/>
     /// is set to <see cref="SizeMode.SizeToContent" />.
@@ -44,9 +44,9 @@ public double? Width
     ///         <description><see cref="Width" /> value is interpreted as double and means proportional sizing. If the width value is <see langword="null"/> 1 is implied</description>
     ///     </item>
     /// </list>
-    /// If mixed <see cref="SizeMode.SizeToContent" /> and <see cref="SizeMode.Fixed" /> widths with <see cref="SizeMode.Star" /> (proportional) widths:<br/>
+    /// If mixed <see cref="SizeMode.SizeToContent" /> and <see cref="SizeMode.Fixed" /> widths with <see cref="SizeMode.Star" /> (proportional) widths:
     /// The <see cref="SizeMode.Star" /> columns are apportioned to the remainder after the <see cref="SizeMode.SizeToContent" /> and
-    /// <see cref="SizeMode.Fixed" /> widths have been calculated.<br/>
+    /// <see cref="SizeMode.Fixed" /> widths have been calculated.
     /// </summary>
     public SizeMode SizeMode
     {

diff --git a/src/Spectre.Console/Widgets/Table/TableColumn.cs b/src/Spectre.Console/Widgets/Table/TableColumn.cs
@@ -17,7 +17,7 @@ public sealed class TableColumn : IColumn
 
     /// <summary>
     /// Gets or sets the width of the column.
-    /// The interpretation of width depends on the value of <see cref="SizeMode"/>.<br/>
+    /// The interpretation of width depends on the value of <see cref="SizeMode"/>.
     /// <br/>
     /// By default it is set to <see langword="null"/>, and the column will size to its contents <see cref="SizeMode.SizeToContent"/>
     /// is set to <see cref="SizeMode.SizeToContent" />.
@@ -37,12 +37,12 @@ public sealed class TableColumn : IColumn
     ///     </item>
     ///     <item>
     ///         <term><see cref="SizeMode.Star">Star (*)</see></term>
-    ///         <description><see cref="Width" /> value is interpreted as double and means proportional sizing.</description>
+    ///         <description><see cref="Width" /> value is interpreted as double and means proportional sizing. If the width value is <see langword="null"/> 1 is implied</description>
     ///     </item>
     /// </list>
-    /// If mixed <see cref="SizeMode.SizeToContent" /> and <see cref="SizeMode.Fixed" /> widths with <see cref="SizeMode.Star" /> (proportional) widths:<br/>
+    /// If mixed <see cref="SizeMode.SizeToContent" /> and <see cref="SizeMode.Fixed" /> widths with <see cref="SizeMode.Star" /> (proportional) widths:
     /// The <see cref="SizeMode.Star" /> columns are apportioned to the remainder after the <see cref="SizeMode.SizeToContent" /> and
-    /// <see cref="SizeMode.Fixed" /> widths have been calculated.<br/>
+    /// <see cref="SizeMode.Fixed" /> widths have been calculated.
     /// </summary>
     public SizeMode SizeMode { get; set; }
 

diff --git a/src/Spectre.Console/Widgets/Table/TableMeasurer.cs b/src/Spectre.Console/Widgets/Table/TableMeasurer.cs
@@ -64,7 +64,7 @@ public List<int> CalculateColumnWidths(int maxWidth)
             widths = CollapseWidths(widths, wrappable, maxWidth);
             tableWidth = widths.Sum();
 
-            // last resort, reduce columns evenly
+            // Last resort, reduce columns evenly
             if (tableWidth > maxWidth)
             {
                 var excessWidth = tableWidth - maxWidth;
@@ -96,19 +96,19 @@ internal Measurement[] MeasureColumns(int maxWidth)
             }
         }
 
-        // index and separate columns
+        // Index and separate columns
         var indexColumns = Columns.Select((column, index) => (column, index)).ToList();
         var fixedColumns = indexColumns.Where(x => x.column.SizeMode != SizeMode.Star);
         var starColumns = indexColumns.Where(x => x.column.SizeMode == SizeMode.Star);
 
-        // first calculate fixed cells
+        // First calculate fixed cells
         var fixedWidth_ranges = fixedColumns.Select(x => (x.index, measurement: MeasureColumn(x.column, maxWidth))).ToList();
 
-        // get remainder
+        // Get remainder
         var consumedWidth = fixedWidth_ranges.Sum(x => x.measurement.Max);
         var totalWidthForStar = Math.Max(0, maxWidth - consumedWidth);
 
-        // and apportioned to the remainder
+        // And apportioned to the remainder
         var starWidth_ranges = MeasureStarColumns(starColumns, totalWidthForStar);
         var width_ranges = fixedWidth_ranges.Concat(starWidth_ranges).OrderBy(x => x.Item1).Select(x => x.Item2);