Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to dependency injection example #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FrankRay78
Copy link

@FrankRay78 FrankRay78 commented Aug 24, 2024

This PR is part of spectreconsole/spectre.console#1620 and should be merged at the same time.


Changes:

  • Updated code example to align with snippet in CommandApp/DI documentation
  • Renamed TypeRegistrar to MyTypeRegistrar, making it more obvious it is a custom class the user must provide.

@welbertwpg
Copy link

I agree 100%. I got confused with the TypeRegistrar example and had to refer to the example code here to understand what I was missing, especially because the package also contains a class with the exact same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants