Skip to content

fix(rhino): colors and materials are preserved on empty layers #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented Jan 30, 2025

Description

Before, we were only sending colros and materials on layers that directly had objects. Layers that didn't have any direct objects but contained other layers with objects did not have their colors and materials sent.

This fixes colors and materials on empty layers.

User Value

Better multiplayer interop workflow from rhino <-> rhino
Sample model: https://latest.speckle.systems/projects/2295cb26a0/models/63ea5caf19

Changes:

  • Rhino send: color unpacker, material unpacker, and layer unpacker

Screenshots:

Original file:
image

Before:

image

After:
image

Validation of changes:

tested sending and receiving with the colors and materials test file

Checklist:

  • [x ] My commits are related to the pull request and do not amend unrelated code or documentation.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

Copy link

linear bot commented Jan 30, 2025

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.79%. Comparing base (593f95d) to head (408cb74).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #542   +/-   ##
=======================================
  Coverage   18.79%   18.79%           
=======================================
  Files         240      240           
  Lines        4883     4883           
  Branches      579      579           
=======================================
  Hits          918      918           
  Misses       3934     3934           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral enabled auto-merge (squash) February 3, 2025 13:07
@oguzhankoral oguzhankoral merged commit 4af9095 into dev Feb 3, 2025
5 checks passed
@oguzhankoral oguzhankoral deleted the claire/cnx-1132-layer-colors-issue branch February 3, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants