Skip to content

chore(template): amends pr template to be more descriptive #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

clairekuang
Copy link
Member

Description & motivation

Amends our pr template to include:

  • pr semantic title conventions
  • better sections including user value

Changes:

  • pr template

Copy link

linear bot commented Jan 29, 2025

@clairekuang clairekuang enabled auto-merge (squash) January 29, 2025 12:51
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.35%. Comparing base (462d01a) to head (965a469).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #535   +/-   ##
=======================================
  Coverage   17.35%   17.35%           
=======================================
  Files         239      239           
  Lines        4805     4805           
  Branches      579      579           
=======================================
  Hits          834      834           
  Misses       3941     3941           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bimgeek bimgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's make sure we follow this structure from now on.

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@clairekuang clairekuang merged commit e4a2908 into dev Jan 29, 2025
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-869-how-to-deliver-prs-template branch January 29, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants