fix(civil3d): handles property exceptions for corridor elements #508
+29
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #508 +/- ##
=====================================
Coverage 9.14% 9.14%
=====================================
Files 228 228
Lines 4310 4310
Branches 543 543
=====================================
Hits 394 394
Misses 3900 3900
Partials 16 16 ☔ View full report in Codecov by Sentry. |
oguzhankoral
approved these changes
Jan 20, 2025
clairekuang
deleted the
claire/cnx-1076-bug-civil-3d-fails-to-push-corridor-error-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Fixes a community-submitted bug for baseline points on corridors that throw due to accessing an offset from baseline property. This pr will omit the
offsetproperty from any point which throws when accessing it.Also fixes a similar bug in offset alignments, that will throw when accessing
offsetproperties, and now skips null corridor solid ids when extracting displayvalues.Fixes #506
Fixes #507
Changes:
Screenshots:
before:
after:
full model with offset alignment:
https://latest.speckle.systems/projects/3f895e614f/models/1737754fb4
corridor with the baseline in the viewer: https://latest.speckle.systems/projects/3f895e614f/models/8c1d9068c3fffc232512c87086dcb369
Validation of changes:
Confirmed with the provided test file