-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Async publish and Async/Sync subscription #505
base: event-aggregator
Are you sure you want to change the base?
Conversation
}; | ||
} | ||
|
||
public virtual Task InvokeAction(Action<TPayload> action, TPayload argument) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the overrides do not use the TopLevelException Handler
We were seeing a crash in Rhino on a OneTimeEventSubscriptionSync
subscribe block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rhino Document switch events are not clearing the UI.
@adamhathcock mentioned this regression may be existing already on dev.
I think it would be good to investigate, since we did at one point have this down.
A lot of things are actually async as well as thread switching is async regardless of source being async or sync. This also matches async by default.
Besides Rhino and Tekla, some apps are using async void for event handing which isn't be a thing.
Requires #417