fix: handling keys with null values in @speckle/objectsender
#3846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Bug fix to the
@speckle/objectsender
package, when an object key hasnull
value.I originally described the bug on the forum
The
#traverse
method was not handling null values are where throwing aTypeError value is null
when reaching line 107 because.speckle_type
couldn't be accessed.I've changed it so that
null
values now are caught in line 60 together with other primitives.I have also updated the test/example case to include a null value to verify my implementation.
Changes:
Screenshots:
N/A
Validation of changes:
nothing: null
togenerateTestObject()
Checklist: