feat(w3c/headers): validate header links #4037
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidvishnoi
reviewed
Feb 16, 2022
sidvishnoi
reviewed
Feb 18, 2022
Comment on lines
+37
to
+43
| ${conf.latestVersion !== null | ||
| ? html`<dt>${l10n.latest_published_version}</dt> | ||
| <dd> | ||
| ${conf.latestVersion | ||
| ${conf.latestVersion !== "" |
There was a problem hiding this comment.
When is it null, and when is it "" in particular?
There was a problem hiding this comment.
When it's null, it shouldn't be included... but when it's ""... I need to check :(
marcoscaceres
force-pushed
the
validate_latest
branch
from
0f3940b to
8d2de1b
Compare
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complains if latestVersion doesn't exist, while it also prevents CG drafts from claiming to have a latestVersion.