Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Flask request_ctx instead of _request_ctx_stack #1583

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Use Flask request_ctx instead of _request_ctx_stack #1583

merged 2 commits into from
Sep 7, 2022

Conversation

RobbeSneyders
Copy link
Member

@RobbeSneyders RobbeSneyders commented Sep 3, 2022 •
edited
Loading

Fixes #1576

Another deprecation warning for Flask 2.3.

Also suppressed first party DeprecationWarnings for which I had to add a pytest.ini file. Since we have quite a lot of config files, we might want to move them to a pyproject.toml file in the future.

nielsbox
nielsbox approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@nielsbox nielsbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the rest

Base automatically changed from feature/flask-json to main September 6, 2022 20:57
@RobbeSneyders RobbeSneyders force-pushed the feature/request-ctx branch 2 times, most recently from 6b93741 to 19acfde Compare September 6, 2022 21:22
@coveralls
Copy link

coveralls commented Sep 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3003473345

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.737%
Totals Coverage Status
Change from base Build 3003331309: 0.0%
Covered Lines: 2718
Relevant Lines: 2869
💛 - Coveralls

@RobbeSneyders RobbeSneyders merged commit 3e52c78 into main Sep 7, 2022
@RobbeSneyders RobbeSneyders deleted the feature/request-ctx branch September 7, 2022 06:35
@osma osma mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsbox nielsbox nielsbox approved these changes

@Ruwann Ruwann Awaiting requested review from Ruwann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pytest generates 2,464 warnings that should be investigated
3 participants
@RobbeSneyders @coveralls @nielsbox