-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update json for Flask 2.3 #1582
Conversation
5f6f9ec
to
dc42c14
Compare
dc42c14
to
0273ac6
Compare
Pull Request Test Coverage Report for Build 2985812338
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we should pin the upper bound Flask version on v2 to 2.2 instead.
I agree with not backporting and pinning the version instead. Seems like an unnecessary breaking change we do not wish to introduce in a minor version increase from a Connexion perspective.
On a side note: Are there features from 2.2> that some users cannot wait for? Maybe an unofficial release could be the answer for that?
2.2 is currently the latest version, so hard to say. Biggest risk is that it will still take a while before we can release 3.X, and we'll be lagging multiple versions behind Flask. Of course we can still choose to backport this later on.
What do you mean with an unofficial release? I wouldn't like to branch our releases even further. We now have 2 branches to maintain (3.X and 2.X) which already requires some additional effort. I wouldn't want to have to support a 3rd :) |
Exactly my thoughts. Since we are currently developing 3.0 we cannot issue a new breaking release (we can from a separate branch, but I don't think it is worth it IMO like you said)
Yeah, I meant exactly that but looking back on my suggestion it seems a bit too much, users will be expecting support and maintenance. So let's just pin it and keep it at that. We can always backport this later on, indeed. |
Ok, I'll submit a PR to the v2 branch to limit the upper version of Flask. |
Partially fixes #1576 by updating the jsonifier and related code to be compatible with Flask 2.3.
Since this new json interface in Flask was only introduced in Flask 2.2, we'll have to pin it as the lower bound version.
I'm doubting if we should backport this to v2. It introduces some breaking changes for users who use custom json encoders, and it would force us to bump the lower bound version of Flask to 2.2 there as well.
If we don't do a backport, we should pin the upper bound Flask version on v2 to 2.2 instead.