Fix async tests #1558
Merged
Fix async tests #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruwann
commented
Jun 22, 2022
| await wrapped_func(request) | ||
|
|
||
| assert exc_info.value.status_code == 403 | ||
| assert exc_info.value.detail == "Provided token doesn't have the required scope" |
There was a problem hiding this comment.
I believe this is because we are now subclassing connexion exceptions from starlette now, which have a different str representation
Pull Request Test Coverage Report for Build 2545700357
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async tests were getting skipped because we didn't have an appropriate pytest setup for it. This PR aims to fix this and adjusts the tests accordingly.