Added more const for external reference to external.go

[neilnaveen]

• Added more const for external.go, from the PR add(package): add const for external reference #153

Signed-off-by: Neil Naveen [email protected]

[lumjjb]

Thanks @neilnaveen for opening this up!

[kzantow]

Hey @neilnaveen if you are going to add these constants (which seems good 👍), could you add all the constants defined in the external references categories and annex f types?

Also these need aliases in the spdx/model.go.

I'd second @lumjjb 's request to replace the hardcoded values with these constants where appropriate, too. I think it would make sense to be part of this PR.

[neilnaveen]

Hey @neilnaveen if you are going to add these constants (which seems good 👍), could you add all the constants defined in the external references categories and annex f types?

Also these need aliases in the spdx/model.go.

I'd second @lumjjb 's request to replace the hardcoded values with these constants where appropriate, too. I think it would make sense to be part of this PR.

I have added all constants from the annex f types, and I have put them in their respective categories.

[kzantow]

Hi @neilnaveen this PR stills seems to be missing a number of changes from the original PR: https://github.com/spdx/tools-golang/pull/153/files it also does not include the aliases in the spdx package, are you able to fix this?

[neilnaveen]

Hi @neilnaveen this PR stills seems to be missing a number of changes from the original PR: https://github.com/spdx/tools-golang/pull/153/files it also does not include the aliases in the spdx package, are you able to fix this?

I have added aliases into spdx/model.go. Could you also tell me which changes I have not added in this PR that was in #153?