-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow and
, or
and with
operators
#892
Conversation
@@ -27,10 +27,16 @@ compound-expression = (simple-expression / | |||
|
|||
simple-expression "WITH" addition-expression / | |||
|
|||
simple-expression "with" addition-expression / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please group the two versions in a single line:
simple-expression ( "WITH" / "with" ) addition-expression
@@ -50,7 +56,7 @@ In the `tag:value` format, a license expression MUST be on a single line, and MU | |||
|
|||
## D.2 Case sensitivity <a name="D.2"></a> | |||
|
|||
License expression operators (`AND`, `OR` and `WITH`) should be matched in a *case-sensitive* manner. | |||
License expression operators (`AND`, `and`, `OR`, `or`, `WITH` and `with`) should be matched in a *case-sensitive* manner. I.e., variations `And`, `oR` are not allowed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the final explanation is needed.
If we want to have it in, reword it to something like:
manner, i.e., letters must be all upper case or all lower case.
This is follow up of discussion https://lists.spdx.org/g/spdx/message/1798 where this was found as good compromise https://lists.spdx.org/g/spdx/message/1817 Signed-off-by: Miroslav Suchý <[email protected]>
Updated. |
ping. @zvr can you please re-review? |
Oh thank you for this! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Going ahead and merging
This is follow up of discussion https://lists.spdx.org/g/spdx/message/1798 where this was found as good compromise https://lists.spdx.org/g/spdx/message/1817
And followup of #876