Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multi SDFG, Fortran] 1) Correctly sort the modules in topological order, 2) This allows propagating the aliasing easily, 3) Deconstruct enums into constant integers, 4) FParser sometimes misidentifies a function call as a structure constructor call, so we fix that too, 5) we can also drop the deconstructed procedures. #1799

Open
wants to merge 6 commits into
base: multi_sdfg
Choose a base branch
from
Open

[Multi SDFG, Fortran] 1) Correctly sort the modules in topological order, 2) This allows propagating the aliasing easily, 3) Deconstruct enums into constant integers, 4) FParser sometimes misidentifies a function call as a structure constructor call, so we fix that too, 5) we can also drop the deconstructed procedures. #1799

wants to merge 6 commits into from

Conversation

pratyai
Copy link
Collaborator

@pratyai pratyai commented Nov 28, 2024

No description provided.

@pratyai
Add explicit constructor to a couple of internal classes. Rewrite a
f3786c7 
function a bit more cleanly.
@pratyai
Alias handling wasn't done correctly on the Fortran AST deconstruction
5ab06fe 
code. Also, if FParser misidentifies function calls as array
construction, fix it there too.
@pratyai
Many things:
288a2bb 
1. Ensure that the modules are added in the topological order.
2. Given #1, we can now handle aliasing better, since for "use all"
   statements, we already have seen all the relevant identifiers, and
   can propagate aliasing appropriately.
3. Deconstruct enumerations into constant integers.
@pratyai pratyai changed the title [Multi SDFG, Fortran] 1) Correctly sort the modules in topological order, 2) This allows propagating the aliasing easily, 3) Deconstruct enums into constant integers [Multi SDFG, Fortran] 1) Correctly sort the modules in topological order, 2) This allows propagating the aliasing easily, 3) Deconstruct enums into constant integers, 4) FParser sometimes misidentifies a function call as a structure constructor call, so we fix that too. Nov 28, 2024
@pratyai pratyai marked this pull request as ready for review November 28, 2024 23:39
@pratyai pratyai changed the title [Multi SDFG, Fortran] 1) Correctly sort the modules in topological order, 2) This allows propagating the aliasing easily, 3) Deconstruct enums into constant integers, 4) FParser sometimes misidentifies a function call as a structure constructor call, so we fix that too. [Multi SDFG, Fortran] 1) Correctly sort the modules in topological order, 2) This allows propagating the aliasing easily, 3) Deconstruct enums into constant integers, 4) FParser sometimes misidentifies a function call as a structure constructor call, so we fix that too, 5) we can also drop the deconstructed procedures. Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acalotoiu acalotoiu Awaiting requested review from acalotoiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pratyai