Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT REVIEW] Fixing a (likely) bug in MapFusion. #1673

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[DO NOT REVIEW] Fixing a (likely) bug in MapFusion. #1673

wants to merge 18 commits into from

Commits on Oct 17, 2024

  1. Fix the issue with cpp codegen, where it currently cannot handle inputs 

    like:
```c++
cpp.reshape_strides(Range([(0, 4, 1), (0, 5, 1)]), None, None, [2, 3, 5])
```
and crashes with an index error.
    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    57edcba View commit details
    Browse the repository at this point in the history

  2. Use integer division, fractions don't make sense here anyway.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    aff5a9e View commit details
    Browse the repository at this point in the history

  3. Add even more tests to cover strides and offsets.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a40ba15 View commit details
    Browse the repository at this point in the history

  4. Start with cleaning up the imports.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a942c5e View commit details
    Browse the repository at this point in the history

  5. Since edge is a loop variable, we probably don't want to use that 

    outside the loop. It seems to be a typo on `iedge`.
    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c0c2519 View commit details
    Browse the repository at this point in the history

  6. Fix a bunch of docstrings and typehints.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0ee87f0 View commit details
    Browse the repository at this point in the history

  7. Remove a couple of redundant == Trues.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    123952c View commit details
    Browse the repository at this point in the history

  8. Since port_created is only a pair (or None), it does not have st and 

    `nd` fields.
    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f7bfa4a View commit details
    Browse the repository at this point in the history

  9. Fix another typehint.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    49719a7 View commit details
    Browse the repository at this point in the history

  10. Fixes for various minor PEP 8 complaints (which are otherwise no-op).

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    851f80a View commit details
    Browse the repository at this point in the history

  11. Typehints and set literal in helpers.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a99bce4 View commit details
    Browse the repository at this point in the history

  12. Move various helper functions out of @staticmethod, since they don't 

    need to be tied to the class itself. Remove their unnecessary arguments.
    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    45d626e View commit details
    Browse the repository at this point in the history

  13. Breakout two pieces of fuse() function into their own helpers.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    288e7c0 View commit details
    Browse the repository at this point in the history

  14. Finally, fix the bug in subgraph fusion that was causing index error.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2b5b851 View commit details
    Browse the repository at this point in the history

  15. Forgot to update the references to subgraph fusion, fixing now 

    + Removing unnecessary imports.
    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c4b6ef6 View commit details
    Browse the repository at this point in the history

  16. Validating halfway in the fusion wasn't a good idea.

    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    bbe8132 View commit details
    Browse the repository at this point in the history

  17. When checking for the "array usage" criteria that can prevent 

    map-fusion, check only within the current state. Otherwise, any "use" of
the array _globally_ (i.e., in the entire SDFG) will cancel the fusion.
    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c0906da View commit details
    Browse the repository at this point in the history

  18. Make sure that the intermediate transient access nodes are not removed 

    if they are used elsewhere.
    @pratyai
    pratyai committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d13cfba View commit details
    Browse the repository at this point in the history