Replace league/url with league/uri & league/uri-components #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakejackson1
force-pushed
the
replace-unsupported-dependency
branch
from
62f1ecf
to
0ff5d8d
Compare
league/url has been abandoned since 2015-09-23 and this PR replaces it with its successor: league/uri and its components package. The package change requires the minimum PHP version to be set to 7.2. PHPUnit was also updated to the last version that supports PHP7.2. I know there was concern about requiring new extensions (spatie#1) by making the switch, however these are not hard dependencies. If you don't use the `league/uri` i18n URI processing feature (`ext-intl`) or don't want to create a data URI from a filepath (`ext-fileinfo`) then there is no issues (an exception is thrown should you use one of these features and don't have the required extension).
jakejackson1
force-pushed
the
replace-unsupported-dependency
branch
from
0ff5d8d
to
4976fa3
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
league/urlhas been abandoned since 2015-09-23 and this PR replaces it with its successor:league/uriand its components packageleague/uri-components.The package change requires the minimum PHP version to be set to 7.2. PHPUnit was also updated to the last version that supports PHP7.2.
I know there was concern about requiring new extensions (#1) by making the switch, however these are not hard dependencies. If you don't use the
league/urii18n URI processing feature (ext-intl) or don't want to create a data URI from a filepath (ext-fileinfo) then there are no issues – an exception is thrown should you use one of these features and don't have the required extension.All existing unit tests pass without any modification.
Please let me know if you require any changes to get this PR merged.
Thanks!