Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop passing null values to explode() #179

Merged
merged 1 commit into from
Jul 27, 2023
Merged

stop passing null values to explode() #179

merged 1 commit into from
Jul 27, 2023

Conversation

Gavrisimo
Copy link
Contributor

This PR is related to this discussion: #168

I have also noticed a lot of these logs in our laravel/nova admin panel:

explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/brain/vendor/spatie/nova-tags-field/src/Tags.php on line 112

The update that I have made simply returns [] when it detects that the value we're dealing with is null.

Signed-off-by: Miloš Gavrilović <[email protected]>
@freekmurze freekmurze merged commit 10f6226 into spatie:main Jul 27, 2023
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants