Move all signature checks into SignatureValidator... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kip signature validation completely via custom validator.
freekmurze
reviewed
Jun 19, 2019
tests/WebhookConfigTest.php
Outdated
| @@ -50,7 +50,7 @@ public function it_validates_the_webhook_profile() | |||
| } | |||
|
|
|||
| /** @test */ | |||
| public function it_validates_the_process_webhook_ojb() | |||
| public function it_validates_the_process_webhook_jpb() | |||
|
Is that issue an issue for merging? lol Seriously though... |
|
I'm a little bit short on time, but I'll be sure to review this PR in coming days or weeks. |
|
I've decided against merging this in for now, because it could be breaking change for people that are using a custom validator. I'll revisit this when creating a new major version. |
|
I've implemented this myself in a clean way. It will be available in v2 which will be released soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables user to skip signature validation completely via custom validator. Simply return true from isValid method and it's skipped.
Moved signature exist check into protected method to give option of extending default validator and reusing functionality.
I didnt really see it necessary to add any new tests this time around. All tests are still passing and if Im honest this was my assumption on behaviour anyway. So I think we're good :)