Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hash_equals order parameters #221

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

sylfel
Copy link
Contributor

@sylfel sylfel commented Aug 7, 2024

In hash_equals documentation, there is a caution

It is important to provide the user-supplied string as the second parameter, rather than the first.

So, I inverted parameters in DefaultSignatureValidator

@freekmurze freekmurze merged commit e71006a into spatie:main Aug 7, 2024
16 checks passed
@freekmurze
Copy link
Member

Thanks!

@sylfel sylfel deleted the hash_equals branch August 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants