Enhance Webhook Client to Support Multiple HTTP Methods for Receiving Requests #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrancu
changed the title
|
The tests are failing could you take a look? |
|
Ok I will check soon. |
|
Hello @freekmurze , |
|
That looks good 👍 Could you also update the readme with a nice example on how to use this new feature? |
|
I have updated the readme. |
|
Thanks! |
|
Thank you so much ❤️ Currently we are working with override. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the package only supports the 'POST' method for receiving webhook requests. However, it would be beneficial to extend this functionality to handle requests with any method, such as 'GET', 'PUT', and more.
One specific use case we encountered was when working with ElasticMail. They send webhook requests using the 'GET' method, which is not currently supported by the package. To ensure compatibility with ElasticMail and other services that utilize different HTTP methods, we need to enhance the webhook client to handle these requests appropriately.