Implement ISO4217 currency validation rule #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new validation rule for validating ISO4217 currencies using their most common form which is a three letter code (examples:
USD
,EUR
,CNY
).Currency()
README.md
descriptionThis implementation intentionally uses the alcohol/iso4217 package for ISO4217 checks (the more downloaded package Payum/iso4217 is a fork of this one and has been abandoned).Note that an alternative could be to rely on the already required package league/iso3166 which includes currency codes (see src/ISO3166.php@L2431), but I was not able to confirm if this list is in fact complete.UPDATE: has been changed to league/iso3166