Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping oh dear when scheduled task has started #85

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Conversation

smknstd
Copy link
Contributor

@smknstd smknstd commented Jan 13, 2023

following https://twitter.com/freekmurze/status/1613630673281028100

I didn't test it yet with the real ohdear API but I put trust into online docs https://ohdear.app/docs/features/cron-job-monitoring

Screenshot 2023-01-13 at 10-21-31 The all-in-one monitoring tool for your entire website - Oh Dear

Can it work ?

@freekmurze
Copy link
Member

In most cases, a starting event is not needed at Oh Dear to determine if a notification should be sent.

We don't want our endpoint to get this extra traffic by default. Therefore, could you put the automatic sending of the starting event behind a config file flag that is false by default?

@freekmurze
Copy link
Member

The tests are failing. Could you take a look at that?

@smknstd
Copy link
Contributor Author

smknstd commented Jan 16, 2023

It should be fixed

@freekmurze freekmurze merged commit bba0cf8 into spatie:main Jan 16, 2023
@freekmurze
Copy link
Member

Thanks!

@smknstd
Copy link
Contributor Author

smknstd commented Jan 16, 2023

Nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants