Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More translations support on health status page #24

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

ahinkle
Copy link
Contributor

@ahinkle ahinkle commented Dec 15, 2021

This PR adds a few translations for a little bit of customization on the health webpage.

@freekmurze
Copy link
Member

Could you take a look at the failing tests? You can run the tests locally with "composer test"

@ahinkle
Copy link
Contributor Author

ahinkle commented Dec 15, 2021

Sorry about that! All set 👍

@freekmurze freekmurze merged commit 1be0d31 into spatie:main Dec 15, 2021
@freekmurze
Copy link
Member

Thanks!

<div class="flex justify-center w-full">
<x-health-logo/>
</div>
@if ($lastRanAt)
<div class="{{ $lastRanAt->diffInMinutes() > 5 ? 'text-red-400' : 'text-gray-400 dark:text-gray-500' }} text-sm text-center font-medium">
Check results from {{ $lastRanAt->diffForHumans() }}
{{ __('health::notifications.check_results_from') }} {{ $lastRanAt->diffForHumans() }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should pass the date to the translation so right-to-left languages can also translate this without it being nonsensical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants