Fixed the CacheCheck causing race conditions in some cases #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple environments, like subdeployments, and you run the
CacheCheck
, it can cause race conditions, because multiple environments write / read the same cache key (laravel-health:check
).By adding the random string from the test cache value to the key itself, we can avoid that race condition.
Also added
Cache->forget()
, so we don't flood the cache with all those randomized keys.