Allow declaring custom or multiple notification classes in health.php #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: When trying to create a custom notification for laravel-health I found out that RunHealthChecksCommand
getFailedNotificationClass()
returns a hardcodedSpatie\Health\Notifications\CheckFailedNotification::class
which makes it impossible to override with your own notification.getFailedNotificationClass()
return the first key (class name) fromconfig('health.notifications.notifications')
This change should not have any effect in existing installations but would allow users to use their own notification by declaring it inside health.php:
@freekmurze I went through the documentation and code and couldn't find another way to do this, other than creating a custom command, but that seemed like an overkill and maybe this could help others who need custom notifications.