Allow to fetch union data properties in unified way #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
reviewed
Apr 7, 2023
tests/DataTest.php
Outdated
| it('can fetch lazy union data', function () { | ||
| $data = UnionData::from(1); | ||
|
|
||
| expect($data->id) |
There was a problem hiding this comment.
I would make separate expectations. Imho the and makes it less readable to see what is actually being tested.
|
Looking good, ping me if you have updated the tests like Freek asked and then I'll tag a new release |
@rubenvanassche , it's updated. |
|
Thanks! |
|
Hmm, I hope this fixes this on Livewire as well. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR came from the discussion #379 . It allows to fetch lazy and non-lazy properties in the same way (regardless the fact how DTO was created - lazy or not).