Add support for Validation Rule Contract in Rule rule #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some tests are failing |
|
Yes. Those failing tests are not related to my pull. After reverting my commit:
tests are still failing:
it seems they are related to typescript tranformer:
It would be weird if my commit, which only adds additional type, was breaking it. |
|
Ok I can see now that it fails in Laravel 9. That's to be expected since new Validation Rule didn't exist back then. Problem is that Laravel Data should have a new major version for Laravel 10 - the way it is right now either Laravel 9 or Laravel 10 is going to fail. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
Illuminate\Contracts\Validation\ValidationRuleinSpatie\LaravelData\Attributes\Validation\Rule. Didn't remove depreciated contracts for compability reasons.