Fill props from route parameters #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties of route parameters)
… trying to get a property from scalar values
|
@rubenvanassche I've updated the implementation based on our discussion and added docs in b87c4ca. Would you mind giving this (and especially the docs) a review and see if this all makes sense? Did I miss anything? |
|
This is looking wonderful, made some small changes in code readability and removed a few sections from the docs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening in place of #303 which was prematurely closed by GH.
Note: I have updated the usage examples below to reflect the latest version of this PR.
This PR introduces 2 new attributes that data properties can leverage to fill them from route parameters:
FromRouteParameter- fills the data property with the route parameter (can be string, integer, object, array, etc)FromRouteParameterProperty- fills the data property with a property from the route parameterThese attributes are handled in the
FillRouteParameterPropertiesDataPipe. The implementation is based on the discussion here, however the details have evolved quite a bit during the original PR's lifetime.Usage examples
See tests for all the possible usage examples and how different configurations are handled.
Docs
Please review the docs on how to use this feature.