Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for phpstan #198

Closed
wants to merge 1 commit into from
Closed

Fix for phpstan #198

wants to merge 1 commit into from

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Aug 17, 2023

With @mixin \Spatie\Image\Manipulations for phpstan the magic methods returns \Spatie\Image\Manipulations but the real return is \Spatie\Image\Image

So when concatenating phpstan give you
Call to an undefined method Spatie\Image\Manipulations::save()

Is there a better way to fix that??

Maybe addig a dumb @method static void save(string $outputPath = '') on \Spatie\Image\Manipulations?

@freekmurze
Copy link
Member

Thanks for your work on this!

I'm going to pass on this one for now.

We'll soon create a new major version of this package that drop the dependency on intervention/image and league/glide.

@freekmurze freekmurze closed this Aug 18, 2023
@josevv28
Copy link

We'll soon create a new major version of this package

@freekmurze hi
If that is going to take time, would it be possible to add this PR until meanwhile? It will only be comments PHPDoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants