-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced holiday dates in Ghana #80
Conversation
Another round of review. |
Kindly review |
PR comments resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
When will this be merged? |
This PR has been in approved state for so long. Hope you haven't forgotten about it |
@@ -5,7 +5,7 @@ | |||
}, | |||
{ | |||
"name": "Constitution Day", | |||
"date": "2024-01-07" | |||
"date": "2024-01-08" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the holiday is on 7th which is sunday so we observed it on 8th,
@@ -5,7 +5,7 @@ | |||
}, | |||
{ | |||
"name": "Constitution Day", | |||
"date": "2024-01-07" | |||
"date": "2024-01-08" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the holiday is on 7th which is sunday so we observed it on 8th,
@@ -5,7 +5,7 @@ | |||
}, | |||
{ | |||
"name": "Constitution Day", | |||
"date": "2024-01-07" | |||
"date": "2024-01-08" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the holiday is on 7th which is sunday so we observed it on 8th,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This PR enhances the holiday dates for Ghana.
Holidays are not observed on weekends so any holiday which falls on a weekend is pushed to the next monday
NB: *** There are no fixed dates for the Eid-Ul-Fitr and Eid-Ul-Adha because they are movable feasts.
The dates for their observation are provided by the Office of the Chief Imam in the course of the year.