Add Support for Liechtenstein #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this branch on main? That way I can run the tests |
Martin-Welte
force-pushed
the
feature/liechtenstein
branch
from
2c4ad1c to
fea6795
Compare
Martin-Welte
force-pushed
the
feature/liechtenstein
branch
from
fea6795 to
613e695
Compare
|
@Nielsvanpach done |
|
Thanks! |
|
It seems I was a bit too quickly with merging this PR. The results in the snapshot don't seem to be correct. Could you PR a fix and verify if the generated results are correct? |
|
@Nielsvanpach yes, will do a fix pr to update liechtenstein snapshot, and reference your comment. |
|
@Nielsvanpach here is the PR for it: #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Additional Information:
There would be 2 extra Hollidays (Easter Sunday, and Pentecost Sunday) but I don't know if that would be in scope of this package.
Source: