Add holidays for South Africa

[pierredup]

No description provided.

[Nielsvanpach]

Thanks! Could you rebase on main, that way I can run the tests here

[Nielsvanpach]

Thanks! Could you fix the failing tests on CI? Probably using $this->easter() will fix it.

[Nielsvanpach]

There are 2 South Africa PRs, but with different results it seems. Could you both verify which one is correct? #32

[pierredup]

Both PRs looks to implement the same days. This one handles an additional edge case, where if a holiday rolls over from the Sunday to the Monday, it shouldn't be added if the Monday is already a Holiday (E.G if 25 Dec falls on a Sunday, it can't roll over to the Monday since the 26 Dec (the following Monday) will already be a holiday).

[johanmeiring]

Ah yes, the edge case that is covered here is indeed correct. This is the more complete implementation, and should be the one that gets merged. I'll close my PR :-)

P.S. I'll try to remember to open a PR once we know what our general election date will be, as that is very likely to be proclaimed a public holiday as well.

[Nielsvanpach]

Thanks!