Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Islamic calendar #214

Merged
merged 34 commits into from
Mar 22, 2024
Merged

Implement Islamic calendar #214

merged 34 commits into from
Mar 22, 2024

Conversation

Nielsvanpach
Copy link
Member

Goals of PR

  • Find a unified way of handling Islamic holidays
  • Use CarbonPeriod for holidays on multiple days
  • Keep the Country class implementation as simple as possible, but still customizable
  • Don't change any test outcomes

@Nielsvanpach Nielsvanpach force-pushed the refactor/islamic-calendar branch from 751110f to 094be29 Compare March 22, 2024 11:38
@Nielsvanpach Nielsvanpach force-pushed the refactor/islamic-calendar branch from eb06c43 to 3529fac Compare March 22, 2024 11:42
@Nielsvanpach Nielsvanpach merged commit e0cf796 into main Mar 22, 2024
28 checks passed
@Nielsvanpach Nielsvanpach deleted the refactor/islamic-calendar branch March 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nielsvanpach