Add Malaysia holiday #17
Conversation
|
Could you rebase this branch, in order to run the tests here? |
pisyek
force-pushed
the
add-malaysia-holiday
branch
2 times, most recently
from
c3bb10d to
77a7443
Compare
| 'swk' => $this->regionSarawak($year), | ||
| 'sgr' => $this->regionSelangor($year), | ||
| 'trg' => $this->regionTerengganu($year), | ||
| default => array_merge( |
There was a problem hiding this comment.
By default I wouldn't return any region specific holidays. What you think?
There was a problem hiding this comment.
i think it is better to add check if region is set; then throw a new exception invalid region if no match. better flow right? @Nielsvanpach
but the reason i put the default to return all is to allow users to get all holidays in Malaysia.
There was a problem hiding this comment.
I'm not aware of the situation in Malaysia, but I think returning all national public holidays by default if no region is given, might be the way to go. This is more in line with implementation for other countries. https://publicholidays.com.my/2024-dates/
pisyek
force-pushed
the
add-malaysia-holiday
branch
2 times, most recently
from
37acfb2 to
f0214a1
Compare
| 'swk' => $this->regionSarawak($year), | ||
| 'sgr' => $this->regionSelangor($year), | ||
| 'trg' => $this->regionTerengganu($year), | ||
| default => array_merge( |
There was a problem hiding this comment.
I'm not aware of the situation in Malaysia, but I think returning all national public holidays by default if no region is given, might be the way to go. This is more in line with implementation for other countries. https://publicholidays.com.my/2024-dates/
|
I'm probably merging this PR soon, so might be best to use his implementation of the ChineseCalendar. |
pisyek
force-pushed
the
add-malaysia-holiday
branch
3 times, most recently
from
029914d to
0455f04
Compare
pisyek
force-pushed
the
add-malaysia-holiday
branch
from
0455f04 to
ab27a90
Compare
pisyek
force-pushed
the
add-malaysia-holiday
branch
from
7f02190 to
5a28447
Compare
pisyek
force-pushed
the
add-malaysia-holiday
branch
from
5a28447 to
c929e4b
Compare
|
Thanks for all the work! |
No description provided.