-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] implement iran holidays #128
Conversation
tests/.pest/snapshots/Countries/IranTest/it_can_calculate_iran_holidays.snap
Show resolved
Hide resolved
@alisalehi1380 thanks for your review |
And the last point, because the main Iranian calendar is the Solar Hijri calendar, using the dates listed in Wikipedia (according to the Gregorian calendar) is limited and has a delay of one day. Left my code and Right your code. I have taken the time to find all these issues and fixed them in my pull request. #146 Regards, Ali Salehi |
@alisalehi1380 Are you sure you checked these dates with the latest version of my changes because this problem has been fixed in the latest version |
@aryala7 Yes, I've solved it in the pull request! 😊 |
->setTimezone('Asia/Tehran'); | ||
|
||
return [ | ||
//add more holidays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which ones are missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nielsvanpach Currently, Islamic holidays cannot be added because they are not fixed every year.For example, some holidays may occur 1 or 2 days earlier or later with the sighting of the moon
Co-authored-by: Niels Vanpachtenbeke <[email protected]>
Co-authored-by: Niels Vanpachtenbeke <[email protected]>
Merged another PR for Iran. Feel free to open a new PR with needed changes! Thanks. |
Contributing a new country ?