Legacy RunnableSolution should continue to extend legacy Solution
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #5, where the legacy
RunnableSolutioninterface was no longer implementing the legacySolutioninterface, which was causing return type errors.I've provided some more information on the issue, along with an example repository which can be used to reproduce the issue: https://github.com/duncanmcclean/spatie-ignition-runnable-solutions-return-type-error
This PR attempts to fix the issue by continuing to extend the legacy
Solutioninterface, which meant having to re-add the runnable solution methods to the interface.