Update setting-the-timeout.md #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At an appropriate place in the documentation, point out a potential problem with CLI server workers when Browsershot is used with Docker.
|
Very good catch, I've lost a couple of hours due to this issue myself 🙃 Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At an appropriate place in the documentation, point out a potential problem with CLI server workers when Browsershot is used with Docker.
After having very confusing timeout issues while generating a lot of browsershots for a PDF document, I found an Issue and a respective comment #516 (comment) that seems to get rid of the problem. I never experienced this problem in production so I was pretty sure it had to do with my local environment, in this case the usual culprits: node version, puppeteer version etc. Of cause I've tried different node and puppeteer versions to get rid of this annoying problem but in the end setting the
PHP_CLI_SERVER_WORKERS(in my case to 20) reduced it to nearly none.I didn't want to propose a specific value, since I assume my 20 workers might be total overkill but 10 weren't enough.
Since it took me a very long time to resolve this or find the root cause, i think this could spare other developers some time.
I was down the rabbit whole checking if my queue:listener restarts messed with the processes etc. just to find out that more cli server workers seem to help best.