This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Add cmd option to choose il2cpp/mono in build tests #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
size/M
gkassabli
reviewed
Dec 19, 2018
workers/unity/Packages/com.improbable.gdk.buildsystem/WorkerBuilder.cs
Outdated
Show resolved
Hide resolved
gkassabli
approved these changes
Dec 19, 2018
paulbalaji
approved these changes
Dec 19, 2018
jamiebrynes7
reviewed
Jan 6, 2019
|
don't think this is mentioned anywhere in the docs right now, but will add the changelog to my other open pr :P |
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Added an optional parameter to enable switching the scripting backend to either il2cpp or mono. This is only exposed when building via cmd. When running it via the menu items in the editor the one that is active in the player settings will be chosen.
Tests
ran it locally. next step is to test it in ci.
Documentation
no documentation needed
Primary reviewers
@firtina-improbable @paulbalaji