Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Feature Request: Make TransformSynchronizationStrategy Apply function public #730

Open
luna-duclos opened this issue Feb 4, 2019 · 0 comments
Labels
A: transform-synchronization Area: Transform synchronization feature module S: being-considered Status: This issue is being considered. T: enhancement Type: This is an improvement to an existing feature

Comments

@luna-duclos
Copy link

luna-duclos commented Feb 4, 2019

Description

When writing a custom ECS system for which TransformSynchronization is wanted, one can setup all the needed Components on the correct entities, however, the TransformSynchronization strategy cannot currently be set from ECS because the Apply function on TransformSynchronizationSendStrategy and TransformSynchronizationReceiveStrategy is internal.
Could this API be made public ?

Expected behaviour

Our own could should be able to call TransformSynchronizationReceiveStrategy.Apply and TransformSynchronizationSendStrategy.Apply

Current behaviour

Function is internal and only accessible within the transformSynchronization module

Possible solution

Make the Apply function public

Steps to reproduce

Write an ECS system that sets up transformSynchronization, for example, in my top-down game, we use server side pathing for the player and only receive the destination coordinates for the client, then do all the pathing server side and sync it back to the client with TransformSynchronization, see snippet here for details if needed: https://gist.github.com/luna-duclos/dc06674a877be04cece8788d3d3bae82

NavInitializationSystem.cs:82 is where the call to apply resides that is currently impossible to do.

@jamiebrynes7 jamiebrynes7 added T: enhancement Type: This is an improvement to an existing feature A: transform-synchronization Area: Transform synchronization feature module S: being-considered Status: This issue is being considered. labels Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: transform-synchronization Area: Transform synchronization feature module S: being-considered Status: This issue is being considered. T: enhancement Type: This is an improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants