Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Make methods in GameObjectCreatorFromMetadata virtual #687

Open
jessicafalk opened this issue Jan 16, 2019 · 1 comment
Open

Make methods in GameObjectCreatorFromMetadata virtual #687

jessicafalk opened this issue Jan 16, 2019 · 1 comment
Labels
A: game-object-creation Area: Gameobject creation feature module S: accepted Status: This issue has been accepted. T: enhancement Type: This is an improvement to an existing feature

Comments

@jessicafalk
Copy link
Contributor

jessicafalk commented Jan 16, 2019 •
edited by jamiebrynes7
Loading

Description

To allow developers to modify the default pipeline for creating and destroying linked game objects, we should make the add a filter method in the GameObjectCreatorFromMetadata and make it virtual. This allows you to add your own custom logic on top of it by inheriting from the class and overriding that one method.
@jessicafalk jessicafalk mentioned this issue Jan 16, 2019
Closed
@jamiebrynes7 jamiebrynes7 added S: accepted Status: This issue has been accepted. A: game-object-creation Area: Gameobject creation feature module T: enhancement Type: This is an improvement to an existing feature labels Jan 16, 2019
@jamiebrynes7 jamiebrynes7 added this to the Release 0.1.4 milestone Jan 16, 2019
@jamiebrynes7
Copy link
Contributor

cc @filod you can follow this issue to track the FR 😄

@jamiebrynes7 jamiebrynes7 removed this from the Release 0.1.5 milestone Feb 4, 2019
jessicafalk pushed a commit that referenced this issue Nov 15, 2019
@Vatyx
Don't update shadow data if we created the entity locally (#687)
75bb470 
* Fixed shadow data being incorrectly reinitialized

* Delete qq

* PR feedback

* Fix compilation
jessicafalk pushed a commit that referenced this issue Nov 15, 2019
@Vatyx
Don't update shadow data if we created the entity locally (#687)
eea26aa 
* Fixed shadow data being incorrectly reinitialized

* Delete qq

* PR feedback

* Fix compilation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A: game-object-creation Area: Gameobject creation feature module S: accepted Status: This issue has been accepted. T: enhancement Type: This is an improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamiebrynes7 @jessicafalk