Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Commit

Permalink
updating code docs and adding two new Project settings files
Browse files Browse the repository at this point in the history
  • Loading branch information
jessicafalk committed Jun 11, 2019
1 parent 3986793 commit 43b3f32
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ public struct WorkerEntityTag : IComponentData
/// <summary>
/// ECS Component added to the worker entity immediately after establishing a connection to a SpatialOS deployment.
/// </summary>
/// <remarks>

This comment has been minimized.

Copy link
@paulbalaji

paulbalaji Jun 11, 2019

Contributor

why did we remove the remark entirely, instead of replacing "reactive"-->"temporary"

/// This is a reactive component and the <see cref="Improbable.Gdk.Core.CleanReactiveComponentsSystem"/> will
/// remove it at the end of the frame.
/// </remarks>
[RemoveAtEndOfTick]
public struct OnConnected : IComponentData
{
Expand All @@ -25,10 +21,6 @@ public struct OnConnected : IComponentData
/// <summary>
/// ECS Component added to the worker entity immediately after disconnecting from SpatialOS
/// </summary>
/// <remarks>
/// This is a reactive component and the <see cref="Improbable.Gdk.Core.CleanReactiveComponentsSystem"/> will
/// remove it at the end of the frame.
/// </remarks>
[RemoveAtEndOfTick]
public struct OnDisconnected : ISharedComponentData, IEquatable<OnDisconnected>
{
Expand Down
11 changes: 11 additions & 0 deletions workers/unity/ProjectSettings/BurstAotSettings_Android.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"MonoBehaviour": {
"m_Enabled": true,
"m_EditorHideFlags": 0,
"m_Name": "",
"m_EditorClassIdentifier": "Unity.Burst.Editor:Unity.Burst.Editor:BurstPlatformAotSettings",
"DisableOptimisations": false,
"DisableSafetyChecks": true,
"DisableBurstCompilation": false
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{

This comment has been minimized.

Copy link
@paulbalaji

paulbalaji Jun 11, 2019

Contributor

what are these project settings for

"MonoBehaviour": {
"m_Enabled": true,
"m_EditorHideFlags": 0,
"m_Name": "",
"m_EditorClassIdentifier": "Unity.Burst.Editor:Unity.Burst.Editor:BurstPlatformAotSettings",
"DisableOptimisations": false,
"DisableSafetyChecks": true,
"DisableBurstCompilation": false
}
}

0 comments on commit 43b3f32

Please sign in to comment.