This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
Deferring the client-worker destroy by a frame #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebrynes7
approved these changes
Jun 12, 2019
| @@ -41,6 +43,11 @@ public bool HasConnected() | |||
| return Worker != null; | |||
| } | |||
|
|
|||
| public void DisconnectPlayer() | |||
| { | |||
| StartCoroutine(PrepareDestroy()); | |||
There was a problem hiding this comment.
We need to find a better pattern for this
zeroZshadow
approved these changes
Jun 12, 2019
jessicafalk
force-pushed
the
bugfix/fix-world-dispose
branch
from
fe11cba to
cd3c1fc
Compare
jessicafalk
added a commit
that referenced
this pull request
Jun 12, 2019
* Release 0.2.3 * updating gdk tools config * Fix mapbuilder in editor (#198) * 2019.1 no longer allows temp scenes in editor mode. Refactored code to work again * Update link.xml * disabled burst compilation (#199) * Make the mobile connector use the Dev Auth Token that's passed through as an argument. (#201) * updated changelog * enable burst just for iOS * remove new line * Deferring the client-worker destroy by a frame (#200) * deferring player destroy by a frame * updating pin * updating pinned version
sputn1ck
added a commit
to sputn1ck/gdk-for-unity-fps-starter-project
that referenced
this pull request
Aug 27, 2020
add heashot damage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
have to defer destroying the worker by a frame to ensure everything gets cleaned up properly.
Tests
ran it, errors did not appear